[Refactor] Share RayCluster across mTLS e2e checks - #5097
Open
HsiaoHungKai wants to merge 5 commits into
Open
Conversation
Signed-off-by: HungKai Hsiao <hsiaohungkai@gmail.com>
Signed-off-by: HungKai Hsiao <hsiaohungkai@gmail.com>
HsiaoHungKai
marked this pull request as ready for review
August 6, 2026 05:47
Author
|
@machichima Please take a look. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
win5923
reviewed
Aug 7, 2026
win5923
left a comment
win5923
left a comment
Member
There was a problem hiding this comment.
Could you fix the lint error? Thanks
Signed-off-by: HungKai Hsiao <hsiaohungkai@gmail.com>
win5923
reviewed
Aug 7, 2026
Signed-off-by: HungKai Hsiao <hsiaohungkai@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit be5ecae. Configure here.
…ut after long run Signed-off-by: HungKai Hsiao <hsiaohungkai@gmail.com>
win5923
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The auto-generated mTLS E2E test previously created separate RayClusters for each validation. This PR reuses a single RayCluster to reduce redundant cluster setup while preserving the existing test coverage.
Related issue number
Part of #5048
Follow-up to this review comment
Labels
doc-updates-requiredlabel.breaking-changelabel.Checks
Manual test instructions
Ran the
TestRayClusterTLSAutoGenerateE2E test successfully: